Add customized admin endpoints #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update configuration docs Change `/storedrequests/amp` -> `/pbs-admin/storedrequests/amp` (settings.in-memory-cache.notification-endpoints-enabled) `/storedrequests/openrtb2` -> `/pbs-admin/storedrequests/openrtb2` (settings.in-memory-cache.notification-endpoints-enabled) `/admin` -> `/pbs-admin/admin` (logger-level-modifier.enabled) `/currency-rates` -> `/pbs-admin/currency-rates` (currency-converter.external-rates.enabled) Keep in mind, that if any enabled, you need to specified corresponding: (bc we don't use default) ``` admin-endpoints.***.on-application-port= admin-endpoints.***.protected= ``` Add configuration differences.
schernysh
reviewed
Feb 17, 2020
src/main/java/org/prebid/server/spring/config/AdminEndpointsConfiguration.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/handler/CustomizedAdminEndpoint.java
Outdated
Show resolved
Hide resolved
schernysh
previously approved these changes
Feb 17, 2020
# Conflicts: # docs/config-app.md # src/main/java/org/prebid/server/spring/config/WebConfiguration.java # src/test/java/org/prebid/server/it/ApplicationTest.java
# Conflicts: # docs/pbs-java-and-go-features-review.md
rpanchyk
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises admin endpoints configuration options:
admin-endpoints.version.*admin-endpoints.currency-rates.*admin-endpoints.storedrequest.*admin-endpoints.storedrequest-amp.*admin-endpoints.cache-invalidation.*admin-endpoints.logger-level-modifier.*Access can be secured with
admin-endpoints.credentialsproperty, like:Also, the path to each endpoint can be changed on demand with
admin-endpoints.NAME.pathproperty.Keep in mind, we disable all admin endpoints by default.